This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
[Minor-change] [file="README.md"] Use of 'sudo' by the root user. #230
Comments
|
+1. It doesn't make sense for the root user to use sudo for dnf. We can either execute the command directly as root or replace # with $ over there. Is anyone working on this? |
|
I agree with @vharsh on keeping with the don't-log-in-as-root practice and using |
|
I would like to work on this, may I? @mattdm |
|
@aditya-konarde Feel free to send the patch in a PR :). |
aditya-konarde
added a commit
to aditya-konarde/Fedora-Dockerfiles
that referenced
this issue
Oct 18, 2016
This pull request fixes issue fedora-cloud#230 Replaced the # before the command with $ since the command uses sudo.
aditya-konarde
added a commit
to aditya-konarde/Fedora-Dockerfiles
that referenced
this issue
Oct 18, 2016
Fixed a minor typo in README.md; Fix fedora-cloud#230
aditya-konarde
added a commit
to aditya-konarde/Fedora-Dockerfiles
that referenced
this issue
Oct 18, 2016
This pull request fixes issue fedora-cloud#230 Replaced the # before the command with $ since the command uses sudo.
|
Looks like I sent the PR to my own fork first(new to git). Anyway the pull request is up for review at #243. Hopefully it will be my first contribution :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The # before the command
sudo dnf install docker fedora-dockerfilesshows that it was performed by the root user.Following the best practices of not logging in as the root user, shouldn't the # be changed to a $ ?
The text was updated successfully, but these errors were encountered: