Drop the 'sent-at' header from messages so tests pass reliably #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase on develop to get CI to pass please? |
jeremycline
force-pushed
the
hacky-fml-fix
branch
from
349ca4f to
9d02bbb
Compare
bowlofeggs
approved these changes
Jan 3, 2019
|
I'm going to re-rebase this so it picks up the new |
bowlofeggs
force-pushed
the
hacky-fml-fix
branch
from
9d02bbb to
8b3b09f
Compare
This header is the time when the message was sent. If the test runs quickly enough the two time stamps could be equal, which is why this doesn't always fail. fixes fedora-infra#2858 Signed-off-by: Jeremy Cline <jcline@redhat.com>
bowlofeggs
force-pushed
the
hacky-fml-fix
branch
from
77fb55e to
9ab9cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header is the time when the message was sent. If the test runs
quickly enough the two time stamps could be equal, which is why this
doesn't always fail.
fixes #2858
Signed-off-by: Jeremy Cline jcline@redhat.com