accept methods as callbacks as well

[TomasTomecek]

Do you also want me to update docs?

[jeremycline]

It'd be good to make sure the documentation is also updated and there's test coverage for this. If you'd like to do that I'd greatly appreciate it, otherwise I can take care of it in the next couple days before I tag a new release.

[jeremycline]

Suggested change

	elif inspect.isfunction(callback) or inspect.ismethod(callback):
	elif callable(callback):

Is the least restrictive, simplest approach. I can't think of any reason to not do this and I don't know what I was thinking restricting it to a function.

[TomasTomecek]

Looking at docs for callable:

    Note that classes are callable, as are instances of classes with a
    __call__() method.

The only problem I see is when someone passes a class as a callback which doesn't implement __call__.

In [1]: class C:
   ...:     pass
   ...: 
   ...: 

In [2]: callable(C)
Out[2]: True

In [3]: callback = C

In [4]: message = {}

In [5]: callback(message)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-5d33cb4c2f38> in <module>()
----> 1 callback(message)

TypeError: C() takes no arguments

[jeremycline]

Indeed. The if inspect.isclass(callback) should handle this particular case, but in general at the moment we don't validate that the callback really does accept only 1 positional argument. It'd be nice to do that and I assume Python has a way to inspect that, but it wouldn't be a regression in functionality since we don't handle this nicely now.

[codecov-io]

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files          13       13           
  Lines        1080     1080           
  Branches      149      149           
=======================================
  Hits         1048     1048           
  Misses         22       22           
  Partials       10       10

Impacted Files	Coverage Δ
fedora_messaging/api.py	100% <ø> (ø)	⬆️
fedora_messaging/_session.py	96.47% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59e150...1ac7246. Read the comment docs.

[TomasTomecek]

Nicely done, thanks for finishing this.

[abompard]

I think this is worth an entry in the news folder for the release notes :-)