Setup logging even when a configuration file isn't supplied #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a configuration file wasn't explicitly supplied, logging would not be set up. Logging should be configured when running the CLI in all cases. Signed-off-by: Jeremy Cline <jcline@redhat.com>
jeremycline
force-pushed
the
always-config-log-cli
branch
from
89bcc14 to
e8a5e29
Compare
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 12 12
Lines 1063 1063
Branches 147 147
=======================================
Hits 1031 1031
Misses 22 22
Partials 10 10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a configuration file wasn't explicitly supplied, logging would not be
set up. Logging should be configured when running the CLI in all cases.
Signed-off-by: Jeremy Cline jcline@redhat.com