-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the message body a public property #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 97.05% 96.88% -0.17%
==========================================
Files 13 13
Lines 1086 1093 +7
Branches 152 152
==========================================
+ Hits 1054 1059 +5
- Misses 22 24 +2
Partials 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should make a 1.3 release now
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Yeah, we should. Do you want me to? Anything else to include in that release? |
Signed-off-by: Jeremy Cline <jcline@redhat.com>
@abompard I can't think of anything. I added some test coverage, so once Travis is happy let's do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 🍰
The message
body
property should be public, otherwise schema writers will have to write an accessor for each dictionary entry, which does not make much sense.