Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the message body a public property #119

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

abompard
Copy link
Member

The message body property should be public, otherwise schema writers will have to write an accessor for each dictionary entry, which does not make much sense.

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #119 into master will decrease coverage by 0.16%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   97.05%   96.88%   -0.17%     
==========================================
  Files          13       13              
  Lines        1086     1093       +7     
  Branches      152      152              
==========================================
+ Hits         1054     1059       +5     
- Misses         22       24       +2     
  Partials       10       10
Impacted Files Coverage Δ
fedora_messaging/message.py 96.63% <80%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67fb323...bbde061. Read the comment docs.

jeremycline
jeremycline previously approved these changes Jan 23, 2019
Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should make a 1.3 release now

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard
Copy link
Member Author

Yeah, we should. Do you want me to? Anything else to include in that release?

Signed-off-by: Jeremy Cline <jcline@redhat.com>
@jeremycline
Copy link
Member

@abompard I can't think of anything. I added some test coverage, so once Travis is happy let's do it.

Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ✨ 🍰

@mergify mergify bot merged commit 04189aa into fedora-infra:master Jan 23, 2019
@abompard abompard deleted the public-body branch January 23, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants