Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the message summary a property #25

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

jeremycline
Copy link
Member

The summary method on the fedora_messaging.message.Message class
is now a property.

This came up during the Flock session so I thought it'd be good to get the change in ASAP and kick out a second alpha.

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files          10       10           
  Lines         744      744           
  Branches      104      104           
=======================================
  Hits          612      612           
  Misses        109      109           
  Partials       23       23
Impacted Files Coverage Δ
fedora_messaging/message.py 94.89% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9cc0a8...479279b. Read the comment docs.

The ``summary`` method on the ``fedora_messaging.message.Message`` class
is now a property.

Signed-off-by: Jeremy Cline <jcline@redhat.com>
Copy link
Member

@pypingou pypingou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@abompard abompard merged commit 0248463 into fedora-infra:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants