Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct sync list, add issue repo and version info #263

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

gridhead
Copy link
Member

Signed-off-by: Akashdeep Dhar akashdeep.dhar@gmail.com

@gridhead gridhead requested review from StephenCoady and LenkaSeg May 16, 2022 09:32
abompard
abompard previously approved these changes May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #263 (4d262c7) into develop (6869c27) will not change coverage.
The diff coverage is n/a.

❗ Current head 4d262c7 differs from pull request most recent head bc00f68. Consider uploading reports for the commit bc00f68 to get more accurate results

@@           Coverage Diff            @@
##           develop     #263   +/-   ##
========================================
  Coverage    88.41%   88.41%           
========================================
  Files           14       14           
  Lines         1174     1174           
  Branches       172      172           
========================================
  Hits          1038     1038           
  Misses         123      123           
  Partials        13       13           
Flag Coverage Δ
unittests 88.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6869c27...bc00f68. Read the comment docs.

@gridhead
Copy link
Member Author

gridhead commented May 17, 2022

@gridhead gridhead force-pushed the fix-packit-conf branch 7 times, most recently from 680a123 to 353fb75 Compare May 17, 2022 02:29
@gridhead
Copy link
Member Author

Hmm. This is strange. I have git installed and I can confirm that I am in the correct directory (ref. https://github.com/fedora-infra/fedora-messaging/runs/6463365423?check_suite_focus=true). It still does not seem to work.

@gridhead gridhead force-pushed the fix-packit-conf branch 3 times, most recently from aa272ab to 20dd50a Compare May 17, 2022 02:48
@gridhead
Copy link
Member Author

This is where I took reference from pre-commit/pre-commit#456. I will go out there and take a walk before I have at this (again).

@abompard
Copy link
Member

Did you have a look at the pre-commit error log? I suspect it may be related to the git safe-directory feature I fixed in FASJSON: fedora-infra/fasjson@8f13c92.
I'll see if I can apply the same fix here.

@abompard abompard changed the base branch from stable to develop May 17, 2022 06:38
@gridhead
Copy link
Member Author

I tried to add a task to cat the logs after the job failed but then I remember that nothing really executes once a command exits out with a non-zero exit code. So it didn't quite work.

@abompard
Copy link
Member

Well, it's more complex than I thought, so it'll have to wait for tomorrow if you don't mind (I'm supposed to be off today ;-) ).

@gridhead
Copy link
Member Author

@abompard, apologies. I am totally okay with waiting on this. I will probably bang my head on Noggin in the meanwhile. :P

@abompard
Copy link
Member

Alright, please rebase, it should pass now.

@gridhead gridhead force-pushed the fix-packit-conf branch 2 times, most recently from 4d262c7 to a91af62 Compare May 19, 2022 09:44
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
@mergify mergify bot merged commit d2ea85f into develop May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants