Fix authentication with x509 certificates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection parameters need to set the credentials type to 'EXTERNAL' in order for x509 client certificate authentication to work. Do so if both the cert and key is present. Signed-off-by: Jeremy Cline <jcline@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 88.41% 88.43% +0.01%
==========================================
Files 10 10
Lines 751 752 +1
Branches 105 105
==========================================
+ Hits 664 665 +1
Misses 60 60
Partials 27 27
Continue to review full report at Codecov.
|
abompard
approved these changes
Aug 20, 2018
|
Yes, I've got a branch in progress, I should have a PR tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection parameters need to set the credentials type to 'EXTERNAL'
in order for x509 client certificate authentication to work. Do so if
both the cert and key is present.
Signed-off-by: Jeremy Cline jcline@redhat.com