Include the queue name messages came from #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumers can consume from multiple queues at once. Consumers may wish to know the name of the queue a message originated from for a number of reasons. This adds ``queue`` instance variable which is set when a message is received from a queue. Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 92.35% 92.43% +0.07%
==========================================
Files 11 11
Lines 798 806 +8
Branches 110 110
==========================================
+ Hits 737 745 +8
Misses 40 40
Partials 21 21
Continue to review full report at Codecov.
|
abompard
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
queueattribute to messages and sets it in the Twisted and not-Twisted backends.The backstory for this is that I'm playing with fmn-next and set up one queue per user per delivery method and set the queue names to be the primary key of the database object with delivery information (irc nick, email address, etc). This means, however, that I need to get the queue name from the message. I think this could be a generally useful attribute, however, so I've made it a public variable in this patch set.