Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework/improve Koji capacity considerations #118

Closed
mizdebsk opened this issue Nov 18, 2016 · 4 comments
Closed

Rework/improve Koji capacity considerations #118

mizdebsk opened this issue Nov 18, 2016 · 4 comments
Assignees
Milestone

Comments

@mizdebsk
Copy link
Member

From historical data Koschei should know which package builds on which architectures (noarch, all arches, or only some subset). This data could be used to better utilize available capacity. This became more important after addition of secondary arches to Fedora primary Koji.

For example, when we exceed ppc64 builder capacity, but still have x86_64 capacity, we can keep submitting noarch builds.

@mizdebsk mizdebsk self-assigned this Nov 29, 2016
@mizdebsk
Copy link
Member Author

@msimacek WDYT about solution like in PoC commit?

@msimacek
Copy link
Contributor

Looks good to me (besides the mentioned missing call to all).

But the "keep submitting" is a bit misleading - if let's say x86_64 load is over limit, but ppc64 is not, it would submit a noarch build only if the build with highest priority is noarch. I assume it's intentional to ensure fairness.

Could you please add a simple testcase for it? (note I merged your VCR code some time ago, so you can use that if you want)

@mizdebsk
Copy link
Member Author

But the "keep submitting" is a bit misleading - if let's say x86_64 load is over limit, but ppc64 is not, it would submit a noarch build only if the build with highest priority is noarch. I assume it's intentional to ensure fairness.

This is intentional for two reasons:

  • to prevent priority inversion (or as you said, "ensure fairness") - otherwise high-priority packages could be preemptied by lower-priority ones
  • because we don't have caching of Koji queries - I didn't want to implement this yet, and repeating Koji RPC calls for next builds seemed like bad idea

Could you please add a simple testcase for it? (note I merged your VCR code some time ago, so you can use that if you want)

Yes, sure. I'll add test cases. Thx for merging VCR code!

@msimacek
Copy link
Contributor

Merged, thank you.

@mizdebsk mizdebsk added this to the 1.9.0 milestone Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants