Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with build group changes #243

Merged
merged 5 commits into from
Feb 20, 2018
Merged

Deal with build group changes #243

merged 5 commits into from
Feb 20, 2018

Conversation

msimacek
Copy link
Contributor

Fixes #242

@codecov
Copy link

codecov bot commented Feb 19, 2018

Codecov Report

Merging #243 into master will increase coverage by 0.21%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   82.34%   82.55%   +0.21%     
==========================================
  Files          41       41              
  Lines        3341     3354      +13     
==========================================
+ Hits         2751     2769      +18     
+ Misses        590      585       -5
Impacted Files Coverage Δ
...gins/copr_plugin/backend/services/copr_resolver.py 80.95% <ø> (ø) ⬆️
koschei/backend/services/repo_resolver.py 90.32% <100%> (+0.06%) ⬆️
koschei/backend/services/resolver.py 96.74% <100%> (ø) ⬆️
koschei/backend/services/build_resolver.py 91.11% <100%> (+6.4%) ⬆️
koschei/backend/koji_util.py 69.51% <72.72%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae56e89...c2bd799. Read the comment docs.

@msimacek msimacek removed the request for review from mizdebsk February 19, 2018 16:53
@msimacek
Copy link
Contributor Author

The function has no test, I need to add one

Copy link
Member

@mizdebsk mizdebsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, tests pass.

@msimacek msimacek merged commit 1bdc595 into master Feb 20, 2018
@msimacek msimacek deleted the group-repo_id branch February 20, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants