Fix build resolution #250
Merged
Fix build resolution #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependency_keys were accidentaly deleted before they were used for comparison.
So that it also tests that the two parts of the process don't stomp on each other's feet.
This is the reason why the tests didn't hit the dependency_keys overwriting bug.
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 82.83% 83.01% +0.17%
==========================================
Files 41 41
Lines 3368 3368
==========================================
+ Hits 2790 2796 +6
+ Misses 578 572 -6
Continue to review full report at Codecov.
|
mizdebsk
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embarassing bug, which caused data loss (== no dependency changes reported) in production. Also there was a bug in the tests, which caused the bug to go undetected, despite the method was covered properly.
I already hotfixed production and triggered re-resolution of affected builds (which unfortunately won't work for builds whose repo is already dead).