Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the security headers #502

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

abompard
Copy link
Member

This PR implements the security headers required in #333. Most of the changes come from the Content Security Policy headers that require us to add nonce attributes to script tags and not use the data: scheme for SVGs in CSS.

@abompard abompard linked an issue Feb 17, 2021 that may be closed by this pull request
5 tasks
@abompard abompard force-pushed the security-headers branch 2 times, most recently from a5de5c4 to 220e25b Compare February 24, 2021 15:51
Copy link
Contributor

@StephenCoady StephenCoady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to add from me, checked it out and does exactly what the top level issue asked for. Theres a conflict on the lock file though. I'll approve anyway for when that's sorted.

Fixes fedora-infra#333

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard merged commit fc86be1 into fedora-infra:dev Feb 25, 2021
@abompard abompard deleted the security-headers branch February 25, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[secaudit-blocking] Missing security headers
2 participants