Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python stdlib for date printing #220

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sgallagher
Copy link
Contributor

Drops the use of the heavyweight Babel library for this single task. The result is not thread-safe, but librpm probably isn't either and rpmautospec is usually run in its own process.

This adds a simple context manager to changelog.py that allows us to set the LC_TIME within a context block, so we don't forget to change it back.

@sgallagher sgallagher requested a review from nphilipp December 11, 2024 18:14
@sgallagher sgallagher self-assigned this Dec 11, 2024
@sgallagher sgallagher force-pushed the timelocale branch 3 times, most recently from ae1cad9 to b6b99f0 Compare December 11, 2024 18:28
Drops the use of the heavyweight Babel library for this single task. The
result is not thread-safe, but librpm probably isn't either and
rpmautospec is usually run in its own process.

This adds a simple context manager to changelog.py that allows us to set
the LC_TIME within a context block, so we don't forget to change it
back.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
Copy link
Member

@nphilipp nphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nphilipp nphilipp merged commit 8efb333 into fedora-infra:main Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants