Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will do:
Problems:
need to add some secrets into this repo to make CI work.
Thanks Antonio, secrets already added. These secrets are all my personal accounts, need to apply/use team-used account, secrets are:
REDHAT_IO_USERNAME,
REDHAT_IO_TOKEN,
STAGE_REDHAT_IO_USERNAME,
STAGE_REDHAT_IO_TOKEN,
QUAY_USERNAME,
QUAY_PASSWORD,
PAT,
TF_API_KEY
The original packit 'tests' job in this repo also uses testing-farm test to run test cases: /packit/installation and /packit/install-and-verify, but somehow with this pr, the same packit 'tests' job turns to run the tmt test plan/test that I added in this pr, instead of it's own test cases. (of course it failed because lack of prepare step)
Seems there is a conflict with packit here, anyone know why? A possible solution is to remove the 'tests' job in packit, it only runs installation, and our CI test cases covers much more.
Should use image-mode runner in CI test as described in https://issues.redhat.com/browse/THEEDGE-4062, but there are some problems for image mode runner need to be fixed.