Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ci test for pull request #164

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

yih-redhat
Copy link
Collaborator

@yih-redhat yih-redhat commented Nov 11, 2024

This PR will do:

  1. Add CI test for each pull request when it is opened, re-opened and synchronized(dev pushed more commits to it).
  2. CI test will run on rpm-package based fedora 41 runner (not image mode runner now as there are some un-resolved problems).
  3. Only one test case added: test greenboot on bootc fedora 41 qcow2 image

Problems:

  1. need to add some secrets into this repo to make CI work.
    Thanks Antonio, secrets already added. These secrets are all my personal accounts, need to apply/use team-used account, secrets are:
    REDHAT_IO_USERNAME,
    REDHAT_IO_TOKEN,
    STAGE_REDHAT_IO_USERNAME,
    STAGE_REDHAT_IO_TOKEN,
    QUAY_USERNAME,
    QUAY_PASSWORD,
    PAT,
    TF_API_KEY

  2. The original packit 'tests' job in this repo also uses testing-farm test to run test cases: /packit/installation and /packit/install-and-verify, but somehow with this pr, the same packit 'tests' job turns to run the tmt test plan/test that I added in this pr, instead of it's own test cases. (of course it failed because lack of prepare step)
    Seems there is a conflict with packit here, anyone know why? A possible solution is to remove the 'tests' job in packit, it only runs installation, and our CI test cases covers much more.

  3. Should use image-mode runner in CI test as described in https://issues.redhat.com/browse/THEEDGE-4062, but there are some problems for image mode runner need to be fixed.

@yih-redhat yih-redhat force-pushed the add-ci branch 3 times, most recently from 7354133 to 4bb6145 Compare November 13, 2024 01:36
say-paul
say-paul previously approved these changes Nov 15, 2024
Copy link
Member

@say-paul say-paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@say-paul say-paul dismissed their stale review November 15, 2024 11:10

pipeline failing

@say-paul say-paul self-requested a review November 18, 2024 06:14
@yih-redhat yih-redhat merged commit 8034580 into fedora-iot:main Nov 18, 2024
6 of 7 checks passed
@yih-redhat yih-redhat deleted the add-ci branch December 5, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants