Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 394: Distributions can choose what does python mean #1

Closed
wants to merge 1 commit into from
Closed

PEP 394: Distributions can choose what does python mean #1

wants to merge 1 commit into from

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented Apr 9, 2019

No description provided.

@hroncok hroncok requested a review from encukou April 9, 2019 13:26
hroncok
hroncok commented Apr 9, 2019
View reviewed changes
pep-0394.txt Outdated Show resolved Hide resolved
pep-0394.txt Show resolved Hide resolved
@hroncok
Copy link
Member Author

hroncok commented Apr 9, 2019

Note that the Application to the CPython Reference Interpreter section would need updating but doing so would not document the reality. I suppose having a make install option for /usr/bin/python (keeping it opt-out on py2 and opt-in on py3) would be ideal. What is the proper procedure? Document the desired state in the PEP and provide a reference PRs for the code at the same time?

encukou
encukou reviewed Apr 9, 2019
View reviewed changes
pep-0394.txt Outdated Show resolved Hide resolved
@encukou
Copy link
Member

encukou commented Apr 12, 2019

I pushed suggestions directly here, do they look OK?

Note that the Application to the CPython Reference Interpreter section would need updating but doing so would not document the reality. I suppose having a make install option for /usr/bin/python (keeping it opt-out on py2 and opt-in on py3) would be ideal. What is the proper procedure? Document the desired state in the PEP and provide a reference PRs for the code at the same time?

I'd leave that be. CPython's choices align with what a distributor is allowed to do.

@hroncok
Copy link
Member Author

hroncok commented Apr 12, 2019

Awesome! Should we submit this as is?

@encukou
Copy link
Member

encukou commented Apr 12, 2019

Sure!

@hroncok hroncok force-pushed the pep394-2019 branch 2 times, most recently from 9c04f4e to 56a7b89 Compare April 12, 2019 14:46
@hroncok @encukou
PEP 394: Distributions can choose what does python mean
68475c0 
Co-Authored-By: Petr Viktorin <encukou@gmail.com>
@hroncok
Copy link
Member Author

hroncok commented Apr 12, 2019

python#989

@hroncok hroncok closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hroncok @encukou