alternatives: isLink should return 0 in case of lstat error

isLink returns non-zero value when a file is a symlink. However, the old code also returned -1 when lsat failed. (cherry picked from commit c55ba54)
fedora-sysv · May 15, 2023 · 52d2562 · 52d2562
1 parent 001ecec
commit 52d2562
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/alternatives.c b/alternatives.c
@@ -484,13 +484,10 @@ static int readConfig(struct alternativeSet *set, const char *title,
 
 static int isLink(char *path) {
     struct stat sbuf;
-    int rc = 0;
 
-    rc = lstat(path, &sbuf);
-    if (!rc) {
-        rc = S_ISLNK(sbuf.st_mode);
-    }
-    return rc;
+    if (lstat(path, &sbuf))
+        return 0;
+    return !!S_ISLNK(sbuf.st_mode);
 }
 
 static int facilityBelongsToUs(char *facility, const char *altDir) {