Fix --keep-foreign when the target is missing completely #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamacku
reviewed
Apr 13, 2023
isLink returns non-zero value when a file is a symlink. However, the old code also returned -1 when lsat failed.
Normally alternatives will only refuse to create a link to /etc/alternatives/* if the file already exists and is not a symlink. But alternatives never checked if existing symlink goes to /etc/alternatives/. This is a weird behavior, but we did not want to change the default behavior so we added --keep-foreign option that is more strict and checks that the target if the symlink is in /etc/alternatives/. But we missed the corner-case where there is no file at all and incorrectly reported on error. Fixes fedora-sysv#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.