Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

square bracket syntax does not work if slug is a keyword #67

Merged
merged 2 commits into from
Dec 7, 2014

Conversation

paul90
Copy link
Member

@paul90 paul90 commented Dec 7, 2014

A probable fix for WardCunningham/Smallest-Federated-Wiki#438

If slug is a keyword, such as clear, the bracket syntax acts on the keyword rather than looking for the page in localStorage.

Attempting to load a page called clear will clear local storage!!!

WardCunningham added a commit that referenced this pull request Dec 7, 2014
square bracket syntax does not work if slug is a keyword
@WardCunningham WardCunningham merged commit 179135c into master Dec 7, 2014
@paul90
Copy link
Member Author

paul90 commented Dec 7, 2014

Published as + wiki-client@0.3.3

@paul90 paul90 deleted the paul90/sfw438 branch December 7, 2014 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants