[pinpoint-apm#117] adaptor error case

feelform · Oct 18, 2022 · 639f0ca · 639f0ca
1 parent 692eb72
commit 639f0ca
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 20 deletions.
diff --git a/lib/supports.js b/lib/supports.js
@@ -6,6 +6,8 @@
 
  'use strict'
 
+ const Logger = require('./utils/logger')
+
  function getLog() {
     return {}
  }

diff --git a/lib/utils/log/logger-output-adaptor.js b/lib/utils/log/logger-output-adaptor.js
@@ -12,24 +12,24 @@ class LoggerOutputAdaptor {
     }
 
     debug(message) {
-        if (!this.output || typeof this.output.debug != 'function') {
-            console.error("The Adaptor doesn't has the debug function.")
+        if (!this.output || typeof this.output.debug != 'function' || typeof this.output.error != 'function') {
+            this.output.error("The Adaptor doesn't has the debug function.")
             return
         }
         this.output.debug(message)
     }
 
     info(message) {
-        if (!this.output || typeof this.output.info != 'function') {
-            console.error("The Adaptor doesn't has the info function.")
+        if (!this.output || typeof this.output.info != 'function' || typeof this.output.error != 'function') {
+            this.output.error("The Adaptor doesn't has the info function.")
             return
         }
         this.output.info(message)
     }
 
     warn(message) {
-        if (!this.output || typeof this.output.warn != 'function') {
-            console.error("The Adaptor doesn't has the warn function.")
+        if (!this.output || typeof this.output.warn != 'function' || typeof this.output.error != 'function') {
+            this.output.error("The Adaptor doesn't has the warn function.")
             return
         }
         this.output.warn(message)

diff --git a/test/utils/log/logger-output-adaptor.test.js b/test/utils/log/logger-output-adaptor.test.js
@@ -10,51 +10,63 @@ const test = require('tape')
 const LoggerOutputAdaptor = require('../../../lib/utils/log/logger-output-adaptor')
 
 test('Adaptor method duck typing validation', (t) => {
-    let actual = new LoggerOutputAdaptor({
+    const error = {
+        error: function () {
+        }
+    }
+
+    let cloneError = Object.assign({}, error)
+    let actual = new LoggerOutputAdaptor(Object.assign(cloneError, {
         debug: function (message) {
             this.actualMessage = message
         }
-    })
+    }))
     actual.debug('message')
     t.equal(actual.output.actualMessage, 'message')
 
-    let actualUnsafe = new LoggerOutputAdaptor({
-    })
+    cloneError = Object.assign({}, error)
+    let actualUnsafe = new LoggerOutputAdaptor(Object.assign(cloneError, {
+    }))
     actualUnsafe.debug('message')
     t.false(actualUnsafe.output.debug, 'this.output.debug is undefined')
 
 
-    actual = new LoggerOutputAdaptor({
+    cloneError = Object.assign({}, error)
+    actual = new LoggerOutputAdaptor(Object.assign(cloneError, {
         info: function (message) {
             this.actualMessage = message
         }
-    })
+    }))
     actual.info('message2')
     t.equal(actual.output.actualMessage, 'message2')
 
-    actualUnsafe = new LoggerOutputAdaptor({
-    })
+    cloneError = Object.assign({}, error)
+    actualUnsafe = new LoggerOutputAdaptor(Object.assign(cloneError, {
+    }))
     actualUnsafe.info('message')
     t.false(actualUnsafe.output.info, 'this.output.info is undefined')
 
-    actual = new LoggerOutputAdaptor({
+    cloneError = Object.assign({}, error)
+    actual = new LoggerOutputAdaptor(Object.assign(cloneError, {
         warn: function (message) {
             this.actualMessage = message
         }
-    })
+    }))
     actual.warn('message3')
     t.equal(actual.output.actualMessage, 'message3')
 
-    actualUnsafe = new LoggerOutputAdaptor({
-    })
+    cloneError = Object.assign({}, error)
+    actualUnsafe = new LoggerOutputAdaptor(Object.assign(cloneError, {
+    }))
     actualUnsafe.warn('message')
     t.false(actualUnsafe.output.warn, 'this.output.warn is undefined')
 
-    actual = new LoggerOutputAdaptor({
+    cloneError = Object.assign({}, error)
+    actual = new LoggerOutputAdaptor(Object.assign(cloneError, {
         error: function (message) {
             this.actualMessage = message
         }
-    })
+    }))
     actual.error('message4')
     t.equal(actual.output.actualMessage, 'message4')