Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 10 opuseads heatfluid #119

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Example 10 opuseads heatfluid #119

wants to merge 6 commits into from

Conversation

prudhomm
Copy link
Member

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you fixed a Bug ?
  • Have you added the documentation of the example or benchmark ?
  • Have you successfully run the example or benchmark?
  • Have you documented the results?
  • Have you added the images to the documentation?
  • Have you added the vtkjs files for 3D visualization in the documentation?
  • Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr

@prudhomm
Copy link
Member Author

@GQMP it seems it was never really finished. could you add results for some parameters with comments please. Since I made the PR I cannot do the review. @romainhild could you do it ?

@prudhomm prudhomm mentioned this pull request Oct 12, 2018
Open
@prudhomm
Copy link
Member Author

but @romainhild the results with analysis are missing in the page

@romainhild
Copy link
Contributor

oops sorry, I read too fast, I thought you wanted to merge immediately.
I'll remove my review, if I can.

romainhild
romainhild suggested changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@romainhild romainhild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add results for some parameters with comments please ?

@prudhomm
Copy link
Member Author

I don't want to merge at all cost. There must be certain components available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainhild romainhild romainhild requested changes

@vincentchabannes vincentchabannes Awaiting requested review from vincentchabannes

At least 1 approving review is required to merge this pull request.

Assignees

@GQMP GQMP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prudhomm @romainhild @GQMP