Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update introduction.adoc #180

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

thomas-saigre
Copy link
Contributor

Add json specifications for boundaries conditions
also minor typo fixes

@prudhomm @vincentchabannes can you please review that this additions are corrects ? I'm not sure in particular of expr1 and expr2 for Robin conditions

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you fixed a Bug ?
  • Have you added the documentation of the example or benchmark ?
  • Have you successfully run the example or benchmark?
  • Have you documented the results?
  • Have you added the images to the documentation?
  • Have you added the vtkjs files for 3D visualization in the documentation?
  • Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr

Add json specifications for boundaries conditions
also minor typo fixes

@prudhomm @vincentchabannes can you please review that this additions are corrects ? I'm not sure in particular of `expr1` and `expr2` for Robin conditions
@thomas-saigre thomas-saigre added domain:documentation Add or revise a unit of documentation toolbox:cfpdes labels Jul 16, 2023
@thomas-saigre thomas-saigre requested a review from prudhomm July 16, 2023 14:37
@prudhomm
Copy link
Member

@thomas-saigre I propose some minor changes

@prudhomm
Copy link
Member

@thomas-saigre @vincentchabannes the PR deploy using netlify should appear any time soon

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for toolboxes-dashing-twilight-9661e1 failed.

Name Link
🔨 Latest commit 1b2c287
🔍 Latest deploy log https://app.netlify.com/sites/toolboxes-dashing-twilight-9661e1/deploys/650c38f856c19f00088dd076

@prudhomm
Copy link
Member

screenshot

@thomas-saigre please could you codeadd some explanation for initial conditions as well ?

Browser metadata
Path:      /toolboxes/latest/cfpdes/manual/
Browser:   Chrome 115.0.0.0 on Mac OS 10.15.7
Viewport:  1728 x 961 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@prudhomm
Copy link
Member

screenshot

perhaps a good idea to have different kind of conditions for different border to examplify ?

Browser metadata
Path:      /toolboxes/latest/cfpdes/manual/
Browser:   Chrome 115.0.0.0 on Mac OS 10.15.7
Viewport:  1728 x 961 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@prudhomm
Copy link
Member

screenshot

perhaps add a comment that this will be considered a non-linear condition due to the presence of heat_T``code ? an alternative to avoid that is to use heat_T_rt (@vincent is this correct?) so that heat_T from previous iteration is used(time or non-linear)

Browser metadata
Path:      /toolboxes/latest/cfpdes/manual/
Browser:   Chrome 115.0.0.0 on Mac OS 10.15.7
Viewport:  1728 x 961 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@prudhomm
Copy link
Member

screenshot

stress out that Robin provide a linear boundary condition so term implying non-linearity cannot be used. Again same trick with _rt (remove trial) could be used to avoid that

Browser metadata
Path:      /toolboxes/latest/cfpdes/manual/
Browser:   Chrome 115.0.0.0 on Mac OS 10.15.7
Viewport:  1728 x 961 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:documentation Add or revise a unit of documentation toolbox:cfpdes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants