-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Db store #98
Merged
Merged
Add Db store #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinql
force-pushed
the
dvl/quentin/dbstore
branch
5 times, most recently
from
December 11, 2023 11:01
2dd37d7
to
0dcac8f
Compare
quentinql
force-pushed
the
dvl/quentin/dbstore
branch
from
December 11, 2023 11:07
0dcac8f
to
88df018
Compare
feenes
reviewed
Dec 12, 2023
feenes
reviewed
Dec 12, 2023
feenes
reviewed
Dec 12, 2023
feenes
reviewed
Dec 12, 2023
klausfmh
suggested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor feedback +
add get
- add tests
quentinql
force-pushed
the
dvl/quentin/dbstore
branch
from
December 12, 2023 16:21
08ce1f7
to
25c158e
Compare
quentinql
force-pushed
the
dvl/quentin/dbstore
branch
from
December 13, 2023 10:54
2b94614
to
b72fc2c
Compare
feenes
reviewed
Dec 13, 2023
feenes
reviewed
Dec 13, 2023
feenes
reviewed
Dec 13, 2023
feenes
reviewed
Dec 13, 2023
klausfmh
reviewed
Dec 14, 2023
klausfmh
reviewed
Dec 14, 2023
klausfmh
reviewed
Dec 14, 2023
klausfmh
reviewed
Dec 14, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
reviewed
Dec 15, 2023
feenes
approved these changes
Dec 15, 2023
feenes
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dbstore that store the 10 lasts probe results (use peewee ORM)
The db store:
- at init, creates 10 fake results if they don't exists for each probes
- a thread store each minutes all probe states (replace the older probe state with the new)
KNOWN BUG: trio doesn't correctly handle signals so the clean shutdown of the thread could cause some obscur error in logs (but before there was not a proper shutdown so now we have a proper db write (not file write) and we just have in addition a weird error in the logs if we cancel the run)