fix gtTrace for zero-argument functions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmine whether it's 'self' (which is customarily used in object methods). It does however not check whether there are any arguments at all, causing gtTrace to fail for standalone functions without any arguments. This fix adds a check on whether there are any arguments before accessing the name of the first argument.
|
[This is an automated comment from the feenk Contributor License Agreement robot.] Hello zeniko! Thanks for your interest in making software development better. Please sign the feenk Contributor License Agreement so we can investigate merging in your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gtTrace checks the name of a method's first argument in order to determine whether it's 'self' (which is customarily used in object methods). It does however not check whether there are any arguments at all, causing gtTrace to fail for standalone functions without any arguments.
This fix adds a check on whether there are any arguments before accessing the name of the first argument.