Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fei withdraw guard #1011

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Fei withdraw guard #1011

merged 2 commits into from
Aug 25, 2022

Conversation

Joeysantoro
Copy link
Contributor

@Joeysantoro Joeysantoro commented Aug 24, 2022

PR Type: Feature

An automated max withdrawal guard for FEI deposits such as Compound/Aave/Fuse. See https://snapshot.fei.money/#/proposal/0xfe4dd76c4bea843fc5a422e1c0cb5dca2f7e985419d2ceeea7618e8c20dcef11

PR Checklist - Feature (Non-Proposal) | Bug

  • All Tests Passing
  • Remove Any .only's on Tests

@Joeysantoro Joeysantoro requested a review from a team as a code owner August 24, 2022 03:35
@eswak
Copy link
Contributor

eswak commented Aug 24, 2022

LGTM, I added calls in the proposal & a deploy step to use this in TIP-121

image

Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good to me

@eswak eswak merged commit b48a183 into feat/tip-121a Aug 25, 2022
@eswak eswak deleted the feat/fei-withdraw-guard branch August 25, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants