Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TC Consolidation #1014

Merged
merged 7 commits into from
Aug 26, 2022
Merged

TC Consolidation #1014

merged 7 commits into from
Aug 26, 2022

Conversation

thomas-waite
Copy link
Contributor

PR Type: Feature|Bug|Release

A description of your PR here.

PR Checklist - Feature (Proposal)

  • All Tests Passing
  • Proposal Added to ProposalsConfig
  • Fork Block Correct
  • Remove Any .only's on Tests
  • Deploy Contract If Needed (+ Verify on Etherscan & Add to MainnetAddresses)
  • Update Documentation If Needed
  • Update Roles Config
  • Update Collateralization Oracle If Needed
  • Proposal Submitted

PR Checklist - Feature (Non-Proposal) | Bug

  • All Tests Passing
  • Remove Any .only's on Tests

PR Checklist - Release

  • All Tests Passing
  • Clean/Empty Proposals Config
  • Update Fork Block
  • Update Docs If Needed

@thomas-waite thomas-waite requested a review from a team as a code owner August 25, 2022 12:41
@thomas-waite thomas-waite self-assigned this Aug 25, 2022
eswak
eswak previously approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@eswak eswak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You aced this one... ggwp

kryptoklob
kryptoklob previously approved these changes Aug 25, 2022
View reviewed changes
@kryptoklob
Copy link
Contributor

kryptoklob commented Aug 25, 2022 •
edited
Loading

Calldata:

0x8f2a0bb000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001e00000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000000000000000000000000000000000000063abaca6ff3c42fc8a6102c9c17e1e90ed24cb7ac4da1bbbaf4754e68f30491300000000000000000000000000000000000000000000000000000000000546000000000000000000000000000000000000000000000000000000000000000008000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca0000000000000000000000005d39721ba1c734b395c2cadbdeec178f688f6ec900000000000000000000000020bc8fe104faded2d0ad9634d745f1488f9991ef000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca000000000000000000000000c7283b66eb1eb5fb86327f08e1b5816b0720212b000000000000000000000000875773784af8135ea0ef43b5a374aad105c5d39e0000000000000000000000006dea81c8171d0ba574754ef6f8b412f2ed88c54d000000000000000000000000c770eefad204b5180df6a14ee197d99d808ee52d00000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000016000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000001e0000000000000000000000000000000000000000000000000000000000000026000000000000000000000000000000000000000000000000000000000000002e0000000000000000000000000000000000000000000000000000000000000036000000000000000000000000000000000000000000000000000000000000003e0000000000000000000000000000000000000000000000000000000000000002442966c68000000000000000000000000000000000000000000237da65b05785f5795244b0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d9600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d960000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c000000000000000000000000000000000000000000026588ba3904de9089b0d3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000289c8025f44154124ecad000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb0000000000000000000000002ec598d8e3df35e5d6f13ae2f05a7bb2704e92ea00000000000000000000000000000000000000000000036421af9fac1830badb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c00000000000000000000000000000000000000000000e93587216489026b968b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000cab6f890445b7dadc140400000000000000000000000000000000000000000000000000000000

Metadata Calldata:

0x9c0b40bf000000000000000000000000000000000000000000000000000000000000001955193dd2c5c14237d3c09ef37044746e726036d168a79310c703b9c3fb3b1aa40000000000000000000000000000000000000000000000000000000000000060000000000000000000000000000000000000000000000000000000000000014d0a20205449502d3132323a2054726962616c20436f756e63696c20636f6e736f6c69646174696f6e0a0a2020312e204275726e206578697374696e67204665692068656c64206279207468652054432074696d656c6f636b0a2020322e20456e642076657374696e67206f66205261726920496e667261737472756374757265207465616d2074696d656c6f636b730a2020332e204772616e742046454920616e6420545249424520617070726f76616c7320746f207468652044414f2074696d656c6f636b2c20736f2066756e64732063616e206265206c61746572206d6f76656420696e20612044414f20766f74650a2020342e2053656e642049444c4520746f2054726962616c20436f756e63696c20536166650a2020352e2053656e6420616c6c2072656d61696e696e672061737365747320746f207468652044414f2074696d656c6f636b0a202000000000000000000000000000000000000000

Execute Calldata:

0xe38335e500000000000000000000000000000000000000000000000000000000000000a000000000000000000000000000000000000000000000000000000000000001c000000000000000000000000000000000000000000000000000000000000002e0000000000000000000000000000000000000000000000000000000000000000063abaca6ff3c42fc8a6102c9c17e1e90ed24cb7ac4da1bbbaf4754e68f3049130000000000000000000000000000000000000000000000000000000000000008000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca0000000000000000000000005d39721ba1c734b395c2cadbdeec178f688f6ec900000000000000000000000020bc8fe104faded2d0ad9634d745f1488f9991ef000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca000000000000000000000000c7283b66eb1eb5fb86327f08e1b5816b0720212b000000000000000000000000875773784af8135ea0ef43b5a374aad105c5d39e0000000000000000000000006dea81c8171d0ba574754ef6f8b412f2ed88c54d000000000000000000000000c770eefad204b5180df6a14ee197d99d808ee52d00000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000016000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000001e0000000000000000000000000000000000000000000000000000000000000026000000000000000000000000000000000000000000000000000000000000002e0000000000000000000000000000000000000000000000000000000000000036000000000000000000000000000000000000000000000000000000000000003e0000000000000000000000000000000000000000000000000000000000000002442966c68000000000000000000000000000000000000000000237da65b05785f5795244b0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d9600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d960000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c000000000000000000000000000000000000000000026588ba3904de9089b0d3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000289c8025f44154124ecad000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb0000000000000000000000002ec598d8e3df35e5d6f13ae2f05a7bb2704e92ea00000000000000000000000000000000000000000000036421af9fac1830badb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c00000000000000000000000000000000000000000000e93587216489026b968b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000cab6f890445b7dadc140400000000000000000000000000000000000000000000000000000000

Pod Executor Calldata:

0x40a4f325000000000000000000000000e0c7de94395b629860cbb3c42995f300f56e6d7a00000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001e00000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000000000000000000000000000000000000063abaca6ff3c42fc8a6102c9c17e1e90ed24cb7ac4da1bbbaf4754e68f3049130000000000000000000000000000000000000000000000000000000000000008000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca0000000000000000000000005d39721ba1c734b395c2cadbdeec178f688f6ec900000000000000000000000020bc8fe104faded2d0ad9634d745f1488f9991ef000000000000000000000000956f47f50a910163d8bf957cf5846d573e7f87ca000000000000000000000000c7283b66eb1eb5fb86327f08e1b5816b0720212b000000000000000000000000875773784af8135ea0ef43b5a374aad105c5d39e0000000000000000000000006dea81c8171d0ba574754ef6f8b412f2ed88c54d000000000000000000000000c770eefad204b5180df6a14ee197d99d808ee52d00000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000016000000000000000000000000000000000000000000000000000000000000001a000000000000000000000000000000000000000000000000000000000000001e0000000000000000000000000000000000000000000000000000000000000026000000000000000000000000000000000000000000000000000000000000002e0000000000000000000000000000000000000000000000000000000000000036000000000000000000000000000000000000000000000000000000000000003e0000000000000000000000000000000000000000000000000000000000000002442966c68000000000000000000000000000000000000000000237da65b05785f5795244b0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d9600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000042526d960000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c000000000000000000000000000000000000000000026588ba3904de9089b0d3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000289c8025f44154124ecad000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb0000000000000000000000002ec598d8e3df35e5d6f13ae2f05a7bb2704e92ea00000000000000000000000000000000000000000000036421af9fac1830badb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c00000000000000000000000000000000000000000000e93587216489026b968b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c0000000000000000000000000000000000000000000cab6f890445b7dadc140400000000000000000000000000000000000000000000000000000000

@Joeysantoro Joeysantoro dismissed stale reviews from kryptoklob and eswak via 572747a August 25, 2022 23:45
@Joeysantoro Joeysantoro merged commit 2647533 into develop Aug 26, 2022
@Joeysantoro Joeysantoro deleted the tc-consolidate branch August 26, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joeysantoro Joeysantoro Joeysantoro approved these changes

@kryptoklob kryptoklob kryptoklob left review comments

@eswak eswak eswak left review comments

Assignees

@thomas-waite thomas-waite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomas-waite @kryptoklob @eswak @Joeysantoro