Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIP-121c: INDEX OTC proposal #1034

Merged
merged 7 commits into from
Sep 15, 2022
Merged

TIP-121c: INDEX OTC proposal #1034

merged 7 commits into from
Sep 15, 2022

Conversation

eswak
Copy link
Contributor

@eswak eswak commented Sep 6, 2022 •
edited
Loading

Deploy an OtcEscrow contract that will receive 200,000 DAI from Wintermute (through a simple transfer() call) and can then accept the trade with the DAO Timelock, by sending 100,000 INDEX to it.

  • All Tests Passing
  • Proposal Added to ProposalsConfig
  • Fork Block Correct
  • Remove Any .only's on Tests
  • Deploy Contract If Needed (+ Verify on Etherscan & Add to MainnetAddresses)
  • Update Documentation If Needed
  • Update Roles Config
  • Update Collateralization Oracle If Needed
  • Proposal Submitted

@eswak eswak requested a review from a team as a code owner September 6, 2022 09:49
@eswak eswak changed the base branch from develop to feat/vlaura-otc September 6, 2022 09:49
@eswak eswak changed the base branch from feat/vlaura-otc to develop September 14, 2022 09:40
@eswak
Copy link
Contributor Author

eswak commented Sep 14, 2022

Calldata :

0x7d5e81e20000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001c0000000000000000000000000000000000000000000000000000000000000042000000000000000000000000000000000000000000000000000000000000000040000000000000000000000000ee81df08b20e4f9e0f534e50da437d24491c4ee0000000000000000000000000954906da0bf32d5479e25f46056d22f08464cab000000000000000000000000574a9a9eed5a3be02bd35255e7e8625fe6824a020000000000000000000000006b175474e89094c44da98b954eedeac495271d0f00000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000018000000000000000000000000000000000000000000000000000000000000001c00000000000000000000000000000000000000000000000000000000000000044f3fef3a3000000000000000000000000d51dba7a94e1adea403553a8235c302cebf41a3c00000000000000000000000000000000000000000000152d02c7e14af6800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b3000000000000000000000000574a9a9eed5a3be02bd35255e7e8625fe6824a0200000000000000000000000000000000000000000000152d02c7e14af68000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000048119c065000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb0000000000000000000000008ffae111ab06f532a18418190129373d14570014000000000000000000000000000000000000000000002a5a058fc295ed0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003365449502d313231633a20494e444558204f54430a0a20205449502d313231633a20494e444558204f54430a0a2020546869732070726f706f73616c2073657473207570207468652070726f746f636f6c20746f2062652061626c6520746f204f544320697473203130302c30303020494e44455820746f2057696e7465726d75746520666f72204f54432074726164652c20696e2065786368616e6765206f66203230302c303030204441492e0a0a202042792070617373696e6720746869732070726f706f73616c2c207468652054726962652044414f20617574686f72697a6573204c61205472696275205341524c20746f206f7065726174652074686973204f5443207472616465206265747765656e207468652054726962652044414f20616e642057696e7465726d7574652054726164696e6720616e64204b5943206f6e20626568616c66206f66207468652044414f2c2062757420746869732064656c65676174696f6e206f6620706f7765722069732073636f70652d6c696d6974656420746f2074686973206f7065726174696f6e206f6e6c792e205468652054726962652044414f20646f6573206e6f7420617574686f72697a65204c61205472696275205341524c20746f20726570726573656e7420697420696e206f7468657220636f6e7465787473206f722074616b6520616e79206f7468657220656e676167656d656e7473206f6e2069747320626568616c662e205468652054726962652044414f207368616c6c206265617220616c6c20726573706f6e736962696c697469657320726567617264696e6720746869732074726164652c20696e636c7564696e67206163636f756e74696e6720616e64207265706f7274696e6720726571756972656d656e74732c206f7220746178206f626c69676174696f6e732e205468652054726962652044414f207368616c6c206b65657020637573746f6479206f66207468652065786368616e6765642066756e647320617420616c6c2074696d65732c20616e64204c61205472696275205341524c206f6e6c792061637473206173206120746563686e6963616c206f70657261746f7220666f722074686973207472616e73616374696f6e2e0a202000000000000000000000

thomas-waite
thomas-waite previously approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@thomas-waite thomas-waite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

kryptoklob
kryptoklob previously approved these changes Sep 14, 2022
View reviewed changes
@eswak eswak merged commit 83089c5 into develop Sep 15, 2022
@eswak eswak deleted the feat/index-otc branch September 15, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kryptoklob kryptoklob kryptoklob approved these changes

@thomas-waite thomas-waite thomas-waite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eswak @kryptoklob @thomas-waite