Withdraw 30M LP tokens from Convex and 10M Fei from D3 Pool

[thomas-waite]

Summary

Withdraws 30M Fei from the Curve D3 pool.

Uses the PCVGuardian to first pull the LP tokens from the Convex PCVDeposit and send them to the Curve PCVDeposit. Then withdraws 10M Fei from the Curve PCVDeposit and sends it to the DAI PSM. Two further transactions will be made in the future to withdraw additional Fei. Makes use of the TribalCouncil to do this.

A Fei Skimmer is also deployed for the DAI PSM to enable Fei to be skimmed off the DAI PSM. A DAO vote is required to do this, as the PCV_CONTROLLER_ROLE needs granting.

[ElliotFriedman]

if you're going to use the onlyGovernorOrAdmin modifier, you have to set the admin of this contract in the constructor

[thomas-waite]

It's set by default in CoreRef, which this contract inherits from, to GOVERNOR. That's a bit redundant at the moment as the GOVERNOR can call this method anyway, but the contract admin could be changed in the future to something else.

Should stay as is imo

[thomas-waite]

Have thought about this some more. In the recent governance upgrade, we changed the admin of the feiSkimmer contracts to the PCV_MINOR_PARAM_ROLE. That role is intended to only manage minor PCV related parameters and should not have the scope to change the source in my opinion (as it would get in this change).

Going to change setSource to be onlyGovernor and then setContractAdmin internally to PCV_MINOR_PARAM_ROLE to avoid having to do later in a DAO vote.

Will then redeploy

[ElliotFriedman]

Cool, that makes sense!