-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP-113: End Departed Rari Founders vesting of TRIBE #896
Conversation
TimelockedDelegator for Tribe
just a minor change to do imo (change the factory for Rari infra team FEI's vesting), otherwise lgtm edit: lol you commited the fix before I commented 💪 |
forking and fast forwarding doesn't rollover properly will fix or delete this test in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (still need to deploy)
proposals/description/clawback.ts
Outdated
target: 'clawbackVestingContractA', | ||
values: '0', | ||
method: 'clawback()', | ||
arguments: (addresses) => [], | ||
description: 'Clawback the TRIBE of Jai Bhavnani and David Lucid' | ||
}, | ||
{ | ||
target: 'clawbackVestingContractB', | ||
values: '0', | ||
method: 'clawback()', | ||
arguments: (addresses) => [], | ||
description: 'Clawback the TRIBE of Jai Bhavnani and David Lucid' | ||
}, | ||
{ | ||
target: 'clawbackVestingContractC', | ||
values: '0', | ||
method: 'clawback()', | ||
arguments: (addresses) => [], | ||
description: 'Clawback the TRIBE of Jai Bhavnani and David Lucid' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the proposal should withdraw all the TRIBE from the timelock back to core after or at least approve some contract like the Tribal Council Timelock to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have approved the TC timelock for 20M and added checks that it was approved and can transfer
// const rariInfraTribeTimelock = await ethers.getContractAt( | ||
// 'LinearTimelockedDelegator', | ||
// addresses.rariInfraTribeTimelock | ||
// ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was leaving in in case I needed to do a redeploy (it's needed during deploy time) and will remove after
// ); | ||
|
||
// rariFeiTimelockRemainingDuration = await rariInfraFeiTimelock.remainingTime(); | ||
// rariTribeTimelockRemainingDuration = await rariInfraTribeTimelock.remainingTime(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was leaving in in case I needed to do a redeploy (it's needed during deploy time) and will remove after
FIP-113: End Departed Rari Founders vesting of TRIBE
Implements the on-chain DAO vote part of https://tribe.fei.money/t/fip-113-end-departed-rari-founders-vesting-of-tribe/4355
Specifically:
Timelock migration is performed by:
beneficiary
of the existing timelocks to the Tribal Council timelockbeneficiary
of the Rari infra team timelocks to be the new Rari ops multisigclawbackAdmin
of the Rari infra team timelocks to be the Tribal Council timelockThe Rari Infra timelocks are linear, so we can simply mint/allocate remaining funds there and set the duration to the remaining duration.
PR Checklist - Feature (Proposal)