Execute VOLT <> FEI OTC #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-waite
force-pushed
the
volt-to-escrow
branch
from
8cf098e
to
e0b4fb2
Compare
|
👍 Don't forget to deprecate volt deposit, volt oracle, and remove the deposit from CR oracle |
thomas-waite
force-pushed
the
volt-to-escrow
branch
from
ebec61d
to
e7c5400
Compare
eswak
previously approved these changes
Jul 26, 2022
proposals/dao/tip_119.ts
Outdated
| await forceEth(voltSafe); | ||
| await contracts.fei | ||
| .connect(voltSafeSigner) | ||
| .transfer(addresses.voltOTCEscrow, ethers.constants.WeiPerEther.mul(10_170_000)); |
There was a problem hiding this comment.
not a big deal but you could have used FEI_LOAN_PAID_BACK here instead of ethers.constants.WeiPerEther.mul(10_170_000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute VOLT <> FEI OTC
Transfers the VOLT to the TC timelock, approves the VOLT OTC escrow contract, executes the swap and then burns the returned 10.17M FEI.