-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: documentLastFocus is null #151
Comments
Thanks for reporting that, but in which scenario it can occur? I can't really imagine one, where you try to close the lightbox before it was ever opened. |
Allows unchecked use of the close button click handler. Refs. - feimosi#151
Scenario is a single page "app" in which I have some custom navigation via URL fragment hashes. When history back and forth buttons are used the click event is pro-actively triggered to close a (potentially) opened baguette-box. Currently I'm running it patched like this: dev...ktomk:patch-1#diff-4634650f8cf2cdceb34291a9bcf4c23f |
Ok, that makes sense. I'll patch it soon 👍 |
Great! I assume you don't need a PR for this otherwise just let me know. |
Fixed in 1cf4ec1 |
Thanks! Will refresh the deps on next website update! |
You're welcome! |
On baguette-box.js:472:9
on triggering the click event of the #close-button element via javascript and when the gallery never was activated before.
The text was updated successfully, but these errors were encountered: