Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted accessibility improvements. #109

Closed
wants to merge 1 commit into from
Closed

Assorted accessibility improvements. #109

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 28, 2016

  • use of roles and other wai-aria attributes
  • focus management when baguetteBox popup is open

This is #99 rebased and cleaned up.

Fixes #98.

/CC @feimosi @2aces

* use of roles and other wai-aria attributes
* focus management when baguetteBox popup is open
function bind(element, event, callback, useCapture) {
if (useCapture === undefined) {
useCapture = false;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment now. Also the if statement is unnecessary - addEventListener will handle undefined gracefully.

@XhmikosR
Copy link
Contributor Author

@feimosi: this isn't my patch; I simply offered to rebase the original patch and quickly fix a few stuff.

@feimosi
Copy link
Owner

feimosi commented May 21, 2016

@XhmikosR I know, but I assumed @2aces is no longer available, so either you can express your opinion on my comments or I can guide you which things should be changed. Eventually I can handle that stuff myself on a new branch if you're busy.

@XhmikosR
Copy link
Contributor Author

I'm very busy with real life so it'd be best if you just cherry picked the
branch and made the changes yourself.
On May 21, 2016 19:08, "Marek Grzybek" notifications@github.com wrote:

@XhmikosR https://github.com/XhmikosR I know, but I assumed @2aces
https://github.com/2aces is no longer available, so either you can
express your opinion on my comments or I can guide you which things should
be changed. Eventually I can handle that stuff myself on a new branch if
you're busy.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#109 (comment)

@feimosi feimosi mentioned this pull request May 27, 2016
@feimosi
Copy link
Owner

feimosi commented May 27, 2016

Continued in #112

@feimosi feimosi closed this May 27, 2016
@XhmikosR XhmikosR deleted the 2aces-acessibility-improvements branch May 28, 2016 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants