Skip to content

Commit

Permalink
Remove code that is unused after publish (facebook#550)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaearon authored and feiqitian committed Oct 25, 2016
1 parent 3b14357 commit 0ff0619
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
"url": "https://github.com/facebookincubator/create-react-app/issues"
},
"scripts": {
"build": "node scripts/build.js --debug-template",
"build": "node scripts/build.js",
"create-react-app": "node global-cli/index.js --scripts-version \"$PWD/`tasks/clean_pack.sh`\"",
"e2e": "tasks/e2e.sh",
"start": "node scripts/start.js --debug-template",
"test": "node scripts/test.js --debug-template --env=jsdom"
"start": "node scripts/start.js",
"test": "node scripts/test.js --env=jsdom"
},
"files": [
"PATENTS",
Expand Down
6 changes: 3 additions & 3 deletions scripts/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ var paths = require('../config/paths');
// Tools like Cloud9 rely on this.
var DEFAULT_PORT = process.env.PORT || 3000;
var compiler;

// TODO: hide this behind a flag and eliminate dead code on eject.
// This shouldn't be exposed to the user.
var handleCompile;

// You can safely remove this after ejecting.
// We only use this block for testing of Create React App itself:
var isSmokeTest = process.argv.some(arg => arg.indexOf('--smoke-test') > -1);
if (isSmokeTest) {
handleCompile = function (err, stats) {
Expand Down
6 changes: 0 additions & 6 deletions scripts/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,6 @@ const paths = require('../config/paths');

const argv = process.argv.slice(2);

// Don't pass this option to Jest
const debugTemplateIndex = argv.indexOf('--debug-template');
if (debugTemplateIndex !== -1) {
argv.splice(debugTemplateIndex, 1);
}

// Watch unless on CI
if (!process.env.CI) {
argv.push('--watch');
Expand Down

0 comments on commit 0ff0619

Please sign in to comment.