Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydrated_bloc)!: HydratedStorage.build should not cache instance #4317

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

felangel
Copy link
Owner

@felangel felangel commented Jan 9, 2025

Status

READY

Breaking Changes

YES

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Jan 9, 2025
@felangel felangel added bug Something isn't working breaking change Enhancement candidate would introduce a breaking change pkg:hydrated_bloc This issue is related to the hydrated_bloc package labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (324dfea) to head (b01291e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          806       806           
=========================================
  Hits           806       806           
Flag Coverage Δ
hydrated_bloc 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel changed the title fix(hydrated_bloc)!: changing hydrated storage without manual close fix(hydrated_bloc)!: HydratedStorage.build should not cache instance Jan 9, 2025
@felangel felangel merged commit c243b58 into master Jan 9, 2025
11 checks passed
@felangel felangel deleted the fix/change-hydrated-storage branch January 9, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Enhancement candidate would introduce a breaking change bug Something isn't working pkg:hydrated_bloc This issue is related to the hydrated_bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: HydratedBloc storage doesn't change without closing previous storage
2 participants