Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot pop with Android back button #89

Merged
merged 4 commits into from
May 31, 2022
Merged

fix: cannot pop with Android back button #89

merged 4 commits into from
May 31, 2022

Conversation

wolfenrain
Copy link
Collaborator

@wolfenrain wolfenrain commented May 11, 2022 •
edited by felangel
Loading

Status

READY

Breaking Changes

NO

Description

PR fix for #84, making the android back button behavior more in line with the Flutter BackButton widget.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Testing

@wolfenrain wolfenrain mentioned this pull request May 11, 2022
Closed
@felangel felangel linked an issue May 11, 2022 that may be closed by this pull request
Cannot pop the page with Android back button when using Navigator.push<Type> #84
Closed
@felangel felangel added the bug Something isn't working label May 11, 2022
@HVitureira
Copy link

this solved my problem, thank you so much 🚀

@felangel felangel self-assigned this May 31, 2022
@felangel felangel marked this pull request as ready for review May 31, 2022 20:05
@felangel felangel self-requested a review as a code owner May 31, 2022 20:05
felangel
felangel approved these changes May 31, 2022
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@felangel felangel merged commit 4292730 into master May 31, 2022
@felangel felangel deleted the fix/cannot-pop-with-android-back-button branch May 31, 2022 20:08
@felangel felangel mentioned this pull request May 31, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@felangel felangel

@wolfenrain wolfenrain

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot pop the page with Android back button when using Navigator.push<Type>
3 participants
@wolfenrain @HVitureira @felangel