Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason_logger): The getter 'STD_HANDLE' isn't defined for the class 'WindowsTerminal' #1298

Conversation

wolfenrain
Copy link
Collaborator

@wolfenrain wolfenrain commented Apr 19, 2024

Status

READY

Description

Potentially fixes #1296

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wolfenrain wolfenrain requested a review from felangel as a code owner April 19, 2024 10:43
@wolfenrain wolfenrain changed the title fix(mason_logger): The getter 'STD_HANDLE' isn't defined for the clas… fix(mason_logger): The getter 'STD_HANDLE' isn't defined for the class 'WindowsTerminal' Apr 19, 2024
@renefloor
Copy link

I think it's best to revert the breaking change first, publish that as 0.2.14 so everybody automatically gets the latest that works, and then apply it again with the correct minimum version of win32 as 0.2.15.

@felangel felangel merged commit 6b6d30c into master Apr 19, 2024
13 of 14 checks passed
@felangel felangel deleted the fix-The-getter-'STD_HANDLE'-isn't-defined-for-the-class-'WindowsTerminal' branch April 19, 2024 14:19
felangel added a commit that referenced this pull request Apr 19, 2024
…the class 'WindowsTerminal' (#1298)"

This reverts commit 6b6d30c.
felangel added a commit that referenced this pull request Apr 19, 2024
…nal`" (#1299)

* Revert "fix(mason_logger): The getter 'STD_HANDLE' isn't defined for the class 'WindowsTerminal' (#1298)"

This reverts commit 6b6d30c.

* Revert "refactor(mason_logger): remove deprecated methods in `WindowsTerminal` (#1286)"

This reverts commit b9dfd9f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: The getter 'STD_HANDLE' isn't defined for the class 'WindowsTerminal'.
4 participants