Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cheerio import caused by update #1037

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix cheerio import caused by update #1037

merged 2 commits into from
Aug 15, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented Aug 15, 2024

🗣 Description

Fix an import failure caused by a breaking change in cheerio 1.0.0.
See:

💭 Motivation and context

Keeping things working.

🧪 Testing

CI

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this Aug 15, 2024
@felddy felddy merged commit 4f822e7 into develop Aug 15, 2024
40 checks passed
@felddy felddy deleted the fix/cheerio branch August 15, 2024 22:58
lumiere-bot bot added a commit to coolguy1771/home-ops that referenced this pull request Aug 17, 2024
…31.0 ) (#5241)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/felddy/foundryvtt](https://togithub.com/felddy/foundryvtt-docker)
| minor | `12.330.0` -> `12.331.0` |

---

### Release Notes

<details>
<summary>felddy/foundryvtt-docker
(docker.io/felddy/foundryvtt)</summary>

###
[`v12.331.0`](https://togithub.com/felddy/foundryvtt-docker/releases/tag/v12.331.0)

[Compare
Source](https://togithub.com/felddy/foundryvtt-docker/compare/v12.330.0...v12.331.0)

This container supports Foundry VTT stable release `12.331`

Please read the official FoundryVTT release notes for details on how to
safely migrate to version `12`.

> \[!note]
> Users migrating from version 11 of this container may be interested in
applying [a patch that will perform module compatibility checks at
startup](https://togithub.com/felddy/foundryvtt-docker/discussions/991).

See:

-   https://foundryvtt.com/releases/12.331
- [Check module `v12` compatibility at container startup:
✅⚠️🟠❌](https://togithub.com/felddy/foundryvtt-docker/discussions/991)

> \[!WARNING]\
> While this is categorized as a stable release there is always a
possibility of unexpected bugs or compatibility issues. As with any time
you update the core software, be sure to perform a complete backup of
your user data to minimize any risk of data loss.

#### What's Changed

- Bump the pip-all group with 2 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[felddy/foundryvtt-docker#1024
- Bump the github-actions-all group across 1 directory with 3 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[felddy/foundryvtt-docker#1034
- Bump the pip-all group across 1 directory with 3 updates by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[felddy/foundryvtt-docker#1033
- Fix cheerio import caused by update by
[@&#8203;felddy](https://togithub.com/felddy) in
[felddy/foundryvtt-docker#1037
- Bump winston from 3.13.1 to 3.14.2 in the npm-all group across 1
directory by [@&#8203;dependabot](https://togithub.com/dependabot) in
[felddy/foundryvtt-docker#1038
- Bump github/codeql-action from 3.26.1 to 3.26.2 in the
github-actions-all group by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[felddy/foundryvtt-docker#1035
- Bump FoundryVTT version to 12.331 by
[@&#8203;felddy](https://togithub.com/felddy) in
[felddy/foundryvtt-docker#1039

**Full Changelog**:
felddy/foundryvtt-docker@v12.330.0...v12.331.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4zNy4wIiwidXBkYXRlZEluVmVyIjoiMzguMzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->

Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant