Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert NodeJS version to 14 #201

Merged
merged 1 commit into from
May 27, 2021
Merged

Revert NodeJS version to 14 #201

merged 1 commit into from
May 27, 2021

Conversation

felddy
Copy link
Owner

@felddy felddy commented May 27, 2021

🗣 Description

Revert NodeJS version from 16 to 14.

This closes issue #196

💭 Motivation and Context

As usual, I've been a bit more aggressive with versions.

Related issues:

🧪 Testing

  • Locally
  • CI
  • Hopefully @vehrka will be able to test.

📷 Screenshots (if appropriate)

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow project standards.
  • All relevant repo and/or project documentation has been updated to reflect
    the changes in this PR.
  • Tests have been added to cover the changes in this PR.
  • All new and existing tests pass.

@felddy felddy added the bug label May 27, 2021
@felddy felddy self-assigned this May 27, 2021
@felddy
Copy link
Owner Author

felddy commented May 27, 2021

@vehrka could you try testing with this image: felddy/foundryvtt:bugfix-node14

This is going to be version 0.8.5 of FoundryVTT.

@felddy felddy changed the title Revert Node version to 14 Revert NodeJS version to 14 May 27, 2021
@vehrka
Copy link

vehrka commented May 27, 2021

@vehrka could you try testing with this image: felddy/foundryvtt:bugfix-node14

This is going to be version 0.8.5 of FoundryVTT.

I can confirm that with felddy/foundryvtt:bugfix-node14 I have Foundry 0.8.5 up and running in my raspi!!!!

@felddy felddy merged commit 1320f6a into develop May 27, 2021
@felddy felddy deleted the bugfix/node14 branch May 27, 2021 15:32
This was referenced May 27, 2021
@felddy
Copy link
Owner Author

felddy commented May 27, 2021

I can confirm that with felddy/foundryvtt:bugfix-node14 I have Foundry 0.8.5 up and running in my raspi!!!!

@vehrka I've released a new build on the :beta tag. It should be done in a few minutes:
https://github.com/felddy/foundryvtt-docker/actions/runs/882867160

You can then switch back to using that tag :beta and pull the new image.

Thank you again for your help.

Sallenmoore pushed a commit to Sallenmoore/foundryvtt-docker that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants