Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NodeJS to version 20 #878

Closed
wants to merge 1 commit into from
Closed

Bump NodeJS to version 20 #878

wants to merge 1 commit into from

Conversation

felddy
Copy link
Owner

@felddy felddy commented Jan 14, 2024

🗣 Description

This bumps the NodeJS version to 20.

💭 Motivation and context

Version 20 of NodeJS has been approved by the FoundryVTT developers.
There is evidence that v20 may also mitigate some of the glibc issues people are having with embedded database binaries.
See:

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@felddy felddy force-pushed the improvement/node-20 branch from 41925b9 to 9a1e17e Compare February 12, 2024 18:33
@felddy felddy disabled auto-merge April 29, 2024 15:47
@felddy
Copy link
Owner Author

felddy commented Oct 21, 2024

It's been over a year since npm started hanging on NodeJS. It does not look a resolution is forthcoming. FoundryVTT v13 will require at least Node 20. The best way forward seems to convert the image base from Alpine to Debian. I will start this work in a new branch, and PR.

See:

@felddy felddy closed this Oct 21, 2024
@felddy felddy deleted the improvement/node-20 branch October 21, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant