Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotfix for issue #697 - v11 database glibc workaround #919

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

felddy
Copy link
Owner

@felddy felddy commented Mar 15, 2024

🗣 Description

This PR add this fix developed in #697 to a script in the patches directory.

💭 Motivation and context

This will make it easier to apply the patch using only the environment variable config instead of creating a local patches directory.

For example:

---
version: "3.8"

services:
  foundry:
    image: felddy/foundryvtt:release
    hostname: my_foundry_host
    volumes:
      - type: bind
        source: <your_data_dir>
        target: /data
    environment:
      - CONTAINER_PATCH_URLS=
        https://raw.githubusercontent.com/felddy/foundryvtt-docker/develop/patches/hotfix_issue_697.sh
      - FOUNDRY_PASSWORD=<your_password>
      - FOUNDRY_USERNAME=<your_username>
      - FOUNDRY_ADMIN_KEY=atropos
    ports:
      - target: 30000
        published: 30000
        protocol: tcp

See:

🧪 Testing

Tested on local instances.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@felddy felddy self-assigned this Mar 15, 2024
@felddy felddy enabled auto-merge March 15, 2024 15:46
@felddy felddy merged commit 2aed8bc into develop Mar 15, 2024
42 checks passed
@felddy felddy deleted the patch/issue-697 branch March 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant