changes to timing info for ticlv5 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA
felicepantaleo
added a commit
that referenced
this pull request
Apr 18, 2024
* Adding missing track variables to the dumper * add configurable local time for UncalibRechits * change the computation of the trackster time * Add track time variables to Dumper * ticlv5: compute candidate time at the vertex * fix warning in TICLCandidate validation * code checks and code format * replace InpuTag with std::string in hgcalValidator_cfi * ticlv5: producer for just merging the two clue3d collections * ticlv5: customise dumper for ticlv5 * ticlv5: fix TICLCandidate constructor * ticlv5: add boundary time and change simTICLCandidate time * ticlv5: remove track quality and fix TICLCandidateProducer * ticlv5: trackster time computation - add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA * ticlv5: set local time in customiseForTICLv5 * code-format and code-checks * ticlv5: fix tracksters in input to candidates in TICLDumper * change 1 and 1. to 1.f * ticlv5: fix candidates creation --------- Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb.wr@gmail.com>
felicepantaleo
added a commit
that referenced
this pull request
Apr 19, 2024
* Adding missing track variables to the dumper * add configurable local time for UncalibRechits * change the computation of the trackster time * Add track time variables to Dumper * ticlv5: compute candidate time at the vertex * fix warning in TICLCandidate validation * code checks and code format * replace InpuTag with std::string in hgcalValidator_cfi * ticlv5: producer for just merging the two clue3d collections * ticlv5: customise dumper for ticlv5 * ticlv5: fix TICLCandidate constructor * ticlv5: add boundary time and change simTICLCandidate time * ticlv5: remove track quality and fix TICLCandidateProducer * ticlv5: trackster time computation - add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA * ticlv5: set local time in customiseForTICLv5 * code-format and code-checks * ticlv5: fix tracksters in input to candidates in TICLDumper * change 1 and 1. to 1.f * ticlv5: fix candidates creation --------- Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb.wr@gmail.com>
felicepantaleo
added a commit
that referenced
this pull request
Apr 19, 2024
* Adding missing track variables to the dumper * add configurable local time for UncalibRechits * change the computation of the trackster time * Add track time variables to Dumper * ticlv5: compute candidate time at the vertex * fix warning in TICLCandidate validation * code checks and code format * replace InpuTag with std::string in hgcalValidator_cfi * ticlv5: producer for just merging the two clue3d collections * ticlv5: customise dumper for ticlv5 * ticlv5: fix TICLCandidate constructor * ticlv5: add boundary time and change simTICLCandidate time * ticlv5: remove track quality and fix TICLCandidateProducer * ticlv5: trackster time computation - add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA * ticlv5: set local time in customiseForTICLv5 * code-format and code-checks * ticlv5: fix tracksters in input to candidates in TICLDumper * change 1 and 1. to 1.f * ticlv5: fix candidates creation --------- Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb.wr@gmail.com>
felicepantaleo
added a commit
that referenced
this pull request
May 2, 2024
* Adding missing track variables to the dumper * add configurable local time for UncalibRechits * change the computation of the trackster time * Add track time variables to Dumper * ticlv5: compute candidate time at the vertex * fix warning in TICLCandidate validation * code checks and code format * replace InpuTag with std::string in hgcalValidator_cfi * ticlv5: producer for just merging the two clue3d collections * ticlv5: customise dumper for ticlv5 * ticlv5: fix TICLCandidate constructor * ticlv5: add boundary time and change simTICLCandidate time * ticlv5: remove track quality and fix TICLCandidateProducer * ticlv5: trackster time computation - add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA * ticlv5: set local time in customiseForTICLv5 * code-format and code-checks * ticlv5: fix tracksters in input to candidates in TICLDumper * change 1 and 1. to 1.f * ticlv5: fix candidates creation --------- Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb.wr@gmail.com>
felicepantaleo
added a commit
that referenced
this pull request
May 30, 2024
* Adding missing track variables to the dumper * add configurable local time for UncalibRechits * change the computation of the trackster time * Add track time variables to Dumper * ticlv5: compute candidate time at the vertex * fix warning in TICLCandidate validation * code checks and code format * replace InpuTag with std::string in hgcalValidator_cfi * ticlv5: producer for just merging the two clue3d collections * ticlv5: customise dumper for ticlv5 * ticlv5: fix TICLCandidate constructor * ticlv5: add boundary time and change simTICLCandidate time * ticlv5: remove track quality and fix TICLCandidateProducer * ticlv5: trackster time computation - add the possibiility to compute local trackster time in PatternReconition plugins - fix arguments order in assignPCA * ticlv5: set local time in customiseForTICLv5 * code-format and code-checks * ticlv5: fix tracksters in input to candidates in TICLDumper * change 1 and 1. to 1.f * ticlv5: fix candidates creation --------- Co-authored-by: Felice Pantaleo <felice.pantaleo@cern.ch> Co-authored-by: Wahid Redjeb <wahid.redjeb.wr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.