-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Update skbase to run sktime's contract validation tests #47
Comments
This specific issue should be resolved by sktime/skbase#323, right? #324 is a "bonus" feature and we should keep the issue open, but for the purpose of |
Yes! It's working with #323. This week I expect to create a PR with some changes in code and without skipping the sktime contract tests. The tests passed in my local machine. |
The test is creating some problems in the CI workflow... it seems to be a common issue with github actions (actions/runner-images#6680), and it may be related to CPU / memory usage. Have you ever experienced it in sktime, @fkiraly ? |
Yes, and we have not fully diagnosed it. Our suspicion is that this happens for memory intensive models, and the approach is selecting test parameters in |
Plus, it seems that |
Locally, the tests are being executed partially but then skipped manually by a particular test case: Output of
|
Should be addressed and explained by sktime/sktime#6587 - let's wait with closing this until the release though. |
As discussed with @fkiraly, the previous version of skbase wasn't properly validating jax.numpy attributes (see sktime/skbase#324)
The tests are now being skipped, but can be properly executed with this update.
The text was updated successfully, but these errors were encountered: