[BUG] safer comparison in deep_equals if np.any(x != y) does not result in boolean
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces a comparison in
deep_equalswith a defensive alternative.Namely,
np.any(x != y)and similar expressions are assumed to result in a boolean, but this may be false in pathological cases, e.g., nested lists or nested numpy arrays with non-numpy objects inside.The defensive replacement should catch any case where the expressions assumed boolean are not boolean, and in that case have the same effect as skipping the test.
If
deep_equalscannot determine equality via the condition, it returnsTrueat the end, so when in doubt objects and estimators are deemed to comply withsklearnorsktimecontracts, in dependent tests.