Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Trend as an Effect #95

Merged
merged 10 commits into from
Jul 24, 2024
Merged

[ENH] Trend as an Effect #95

merged 10 commits into from
Jul 24, 2024

Conversation

felipeangelimvieira
Copy link
Owner

@felipeangelimvieira felipeangelimvieira commented Jul 22, 2024

This PR further changes Effect API so that Trend models also use BaseEffect and same conventions.

  • fit receives y, X and scale. Returns None.
  • transform receives X and fh, where fh must be an index. It eturns the data that will be used in predict.
  • predict receives data (with the output of transform) and predicted_effects, which can be a dict with previous predicted effects (including trend).

Trend classes are now within prophetverse.effects.trend.

Next PR will take care of documentation updates

@felipeangelimvieira felipeangelimvieira added the enhancement New feature or request label Jul 22, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.64%. Comparing base (591099e) to head (cc948e5).

Files Patch % Lines
src/prophetverse/sktime/base.py 93.18% 3 Missing ⚠️
src/prophetverse/effects/base.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   93.69%   94.64%   +0.94%     
==========================================
  Files          26       26              
  Lines        1190     1177      -13     
==========================================
- Hits         1115     1114       -1     
+ Misses         75       63      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipeangelimvieira felipeangelimvieira marked this pull request as ready for review July 24, 2024 13:01
@felipeangelimvieira felipeangelimvieira merged commit fd9b99f into main Jul 24, 2024
14 checks passed
@felipeangelimvieira felipeangelimvieira deleted the feature/trend_as_effect branch July 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant