Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log levels too high #7

Closed
ahmetb opened this issue Nov 19, 2011 · 10 comments
Closed

Log levels too high #7

ahmetb opened this issue Nov 19, 2011 · 10 comments

Comments

@ahmetb
Copy link

ahmetb commented Nov 19, 2011

Great module! I'm using it and very pleased. However, I used to keep log reporting level of my application at ≥DEBUG. This causes almost all log messages of RabbiMQ to show. I think only Message Sent and Message Received (high-level) messages should be in DEBUG mode. I see lots of non-useful messages and MQ stats even in INFO mode.

That is not supposed to be like this and if they are coming from this module, we can discuss about convenience of setting log levels reasonably. I'd appreciate your interest and thank you again for such a good plugin!

@feliperazeek
Copy link
Owner

That's a good point, I will change that....

@ahmetb
Copy link
Author

ahmetb commented Nov 20, 2011

I'd recommend you to put only recvd/sent msgs to DEBUG, errors to ERROR and
the rest to TRACE.
On Nov 20, 2011 9:16 PM, "Felipe Oliveira" <
reply@reply.github.com>
wrote:

That's a good point, I will change that....


Reply to this email directly or view it on GitHub:
#7 (comment)

@feliperazeek
Copy link
Owner

I am just pretty swamped at this moment so if you need earlier please feel free to change and issue a pull request. If you do I will release a new version of the plugin.

Btw how are you using the module? Prod or just dev? Just out of curiosity....

Thank you,
Felipe

On Nov 20, 2011, at 11:18 AM, ahmet alp balkanreply@reply.github.com wrote:

I'd recommend you to put only recvd/sent msgs to DEBUG, errors to ERROR and
the rest to TRACE.
On Nov 20, 2011 9:16 PM, "Felipe Oliveira" <
reply@reply.github.com>
wrote:

That's a good point, I will change that....


Reply to this email directly or view it on GitHub:
#7 (comment)


Reply to this email directly or view it on GitHub:
#7 (comment)

@ahmetb
Copy link
Author

ahmetb commented Nov 20, 2011

OK I'll have a look at it. I will be using it in PROD.

Ahmet Balkan
http://ahmetalpbalkan.com
On Nov 20, 2011 9:32 PM, "Felipe Oliveira" <
reply@reply.github.com>
wrote:

I am just pretty swamped at this moment so if you need earlier please feel
free to change and issue a pull request. If you do I will release a new
version of the plugin.

Btw how are you using the module? Prod or just dev? Just out of
curiosity....

Thank you,
Felipe

On Nov 20, 2011, at 11:18 AM, ahmet alp balkanreply@reply.github.com
wrote:

I'd recommend you to put only recvd/sent msgs to DEBUG, errors to ERROR
and
the rest to TRACE.
On Nov 20, 2011 9:16 PM, "Felipe Oliveira" <
reply@reply.github.com>
wrote:

That's a good point, I will change that....


Reply to this email directly or view it on GitHub:

#7 (comment)


Reply to this email directly or view it on GitHub:

#7 (comment)


Reply to this email directly or view it on GitHub:
#7 (comment)

@ahmetb
Copy link
Author

ahmetb commented Nov 21, 2011

How do you build this plugin? I haven't built any play plugins before? ant gives ${play.path} not found error. I'd help on this if you can tell me about build steps to get the actual jar file.

@feliperazeek
Copy link
Owner

Just run "play build-module".

@ahmetb
Copy link
Author

ahmetb commented Nov 21, 2011

I checked out this project under play-1.2.3/modules/ into rabbitmq-0.3 folder and ran that command.

BUILD FAILED
/Users/alp/play-1.2.3/modules/rabbitmq-0.3/build.xml:40: /Users/alp/play-1.2.3/modules/rabbitmq-0.3/lib does not exist.

What do you think?

@ahmetb
Copy link
Author

ahmetb commented Nov 22, 2011

Ping.

@feliperazeek
Copy link
Owner

You need to "mv conf/application.conf.debug conf/application.conf" and then "play dependencies". Right before you commit rename application.conf back to application.conf.debug.

@ahmetb
Copy link
Author

ahmetb commented Mar 7, 2012

Are you planning to make an improvement for this?

@ahmetb ahmetb closed this as completed Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants