Skip to content

Conversation

@Chromatius
Copy link

Description

Make exemplars work for the ASGI and WSGI instrumentations.

This should be an isolated change that does not impact anything else.

Fixes open-telemetry#3031

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

New unit tests were added to confirm that exemplars were not added in the original versions. These tests are passing after the fix.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Chromatius Chromatius changed the base branch from main to 3031-asgi-wsgi-exemplars September 12, 2025 12:18
@felix-hilden felix-hilden force-pushed the 3031-asgi-wsgi-exemplars branch from dd03138 to dba7521 Compare September 13, 2025 06:17
@felix-hilden
Copy link
Owner

Many thanks! All looks good at least for us to present it to the OTEL repo. I rebased on the most recent main too so the changes are clean now. But why the uv.lock change?

@Chromatius
Copy link
Author

The uv.lock changes came from just installing the repo and were not needed for the PR. I have reverted those changes now.

@felix-hilden felix-hilden merged commit 889a129 into felix-hilden:3031-asgi-wsgi-exemplars Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix exemplar support

2 participants