Optional album label (#300)

felix-hilden · Oct 14, 2023 · 08c9ea4 · 08c9ea4
1 parent 3a77ed0
commit 08c9ea4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/docs/src/release_notes.rst b/docs/src/release_notes.rst
@@ -3,6 +3,12 @@
 
 Release notes
 =============
+Unreleased
+----------
+Fixed
+*****
+- Make :class:`Album <model.Album>` optional (:issue:`300`)
+
 5.1.0 (2023-10-04)
 ------------------
 Added

diff --git a/src/tekore/_model/album/full.py b/src/tekore/_model/album/full.py
@@ -1,5 +1,5 @@
 from datetime import datetime
-from typing import List
+from typing import List, Optional
 
 from ..album.base import Album
 from ..member import Copyright
@@ -21,7 +21,7 @@ class FullAlbum(Album):
  copyrights: List[Copyright]
  external_ids: dict
  genres: List[str]
- label: str
+ label: Optional[str]
  popularity: int
  tracks: SimpleTrackPaging
 

diff --git a/tests/client/player.py b/tests/client/player.py
@@ -59,8 +59,11 @@ def setup(user_client):
  user_client.playback_volume(device.volume_percent, device.id)
 
 
+SLEEP_SECS = 5
+
+
 def currently_playing(client):
- sleep(5)
+ sleep(SLEEP_SECS)
  return client.playback_currently_playing()
 
 
@@ -144,6 +147,7 @@ def test_player(self, user_client, setup):
 
  # Queue consumed on next
  user_client.playback_queue_add(to_uri("track", track_ids[0]))
+ sleep(SLEEP_SECS)
  assert len(user_client.playback_queue().queue) > 0
  user_client.playback_next()
  assert_playing(user_client, track_ids[0])