Correctly compare length of argument vector to argument position

felix-hilden · Feb 17, 2020 · 33f9013 · 33f9013
1 parent 01aaece
commit 33f9013
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/tekore/client/decor/__init__.py b/tekore/client/decor/__init__.py
@@ -58,7 +58,7 @@ def decorator(function: Callable) -> Callable:
 
  @wraps(function)
  def wrapper(self, *args, **kwargs):
- if self.max_limits_on and len(args) < arg_pos:
+ if self.max_limits_on and len(args) <= arg_pos:
  kwargs.setdefault('limit', max_limit)
  return function(self, *args, **kwargs)
  return wrapper

diff --git a/tests/client/full.py b/tests/client/full.py
@@ -66,6 +66,14 @@ def test_specifying_limit_pos_arg_overrides_max_limits(self):
 
  self.assertEqual(s.limit, 1)
 
+ def test_specifying_pos_args_until_limit(self):
+ client = Spotify(self.user_token, max_limits_on=True)
+ s1, = client.search('piano', ('track',), None, None)
+ with client.max_limits(False):
+ s2, = client.search('piano', ('track',), None, None)
+
+ self.assertGreater(s1.limit, s2.limit)
+
 
 class TestSpotifyPaging(TestCaseWithUserCredentials):
  @classmethod