Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of throttled Spotify API calls #142

Closed
alexpogue opened this issue Feb 2, 2020 · 3 comments
Closed

Handling of throttled Spotify API calls #142

alexpogue opened this issue Feb 2, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@alexpogue
Copy link

alexpogue commented Feb 2, 2020

Hey Felix, thanks for the amazing library! Looks tons better than the old spotipy repo. Glad you took this over!

I found a possible issue - I get an error when fields parameter is specified for playlist(...). I would expect the function to return either a playlist or an object depending on whether fields is specified (similar to the behavior of playlist_tracks(...) at https://github.com/felix-hilden/tekore/blob/master/tekore/client/api/playlist/view.py#L117), but instead it appears to only ever return a FullPlaylist (see https://github.com/felix-hilden/tekore/blob/master/tekore/client/api/playlist/view.py#L73). Is there a reason you chose not to return a union of playlist and object for playlist(...)?

Thanks again, you're the best!

@felix-hilden
Copy link
Owner

Thank you for your kind words!

Yeah, that's clearly just an oversight on my part. It should be similar to the tracks call. I'll fix it right away.

@felix-hilden felix-hilden self-assigned this Feb 2, 2020
@felix-hilden felix-hilden added the bug Something isn't working label Feb 2, 2020
@felix-hilden
Copy link
Owner

Expect this to ship with the next release!

@felix-hilden
Copy link
Owner

And to clarify the references, somewhat embarrassingly I had to redo the commit twice. So the latest reference is valid. I'm still not quite accustomed to properly making release notes with each commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants