-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of throttled Spotify API calls #142
Labels
bug
Something isn't working
Comments
Thank you for your kind words! Yeah, that's clearly just an oversight on my part. It should be similar to the tracks call. I'll fix it right away. |
Expect this to ship with the next release! |
felix-hilden
added a commit
that referenced
this issue
Feb 2, 2020
felix-hilden
added a commit
that referenced
this issue
Feb 2, 2020
And to clarify the references, somewhat embarrassingly I had to redo the commit twice. So the latest reference is valid. I'm still not quite accustomed to properly making release notes with each commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey Felix, thanks for the amazing library! Looks tons better than the old spotipy repo. Glad you took this over!
I found a possible issue - I get an error when
fields
parameter is specified forplaylist(...)
. I would expect the function to return either aplaylist
or anobject
depending on whether fields is specified (similar to the behavior ofplaylist_tracks(...)
at https://github.com/felix-hilden/tekore/blob/master/tekore/client/api/playlist/view.py#L117), but instead it appears to only ever return aFullPlaylist
(see https://github.com/felix-hilden/tekore/blob/master/tekore/client/api/playlist/view.py#L73). Is there a reason you chose not to return a union ofplaylist
andobject
forplaylist(...)
?Thanks again, you're the best!
The text was updated successfully, but these errors were encountered: