Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on NPM as @types package #6

Open
carlpaten opened this issue Sep 10, 2017 · 4 comments
Open

Publish on NPM as @types package #6

carlpaten opened this issue Sep 10, 2017 · 4 comments

Comments

@carlpaten
Copy link

Since TypeScript 2.x, typings are installed via npm install @types/<package>. It would be nice if this were available under npm install @types/photoshop.

@felixSchl
Copy link
Owner

Great idea. Do you want to submit a PR with required changes to this repo for it to be compatible? From having a quick browse through their docs it says you should not use /// <reference> anymore, and i am not sure how this would then be handled. From what I understand in order to get it published under @types you just submit a PR to them. So once we're happy with the typings in this repo we can go over there and submit a PR. I also think we should release a package for each of the currently supported versions, i.e. npm install @types/photoshop-cs6 etc.

We need to update:

@carlpaten
Copy link
Author

I'm tentatively up for it, could be a couple weeks before I have anything PR-worthy though.

@perludum
Copy link
Collaborator

awesome, I appreciate it very much!

Regarding declaration files for UnitValue and ScriptUI it might be an idea to add early beta files to the repo with some initial declarations. People could add new blocks from time to time with pull requests by following the order of the prose "JavaScript Tools Guide".

(Unfortunately, I’m too unexperienced writing ts declarations so far to give it a start)

@xiaoweiSun
Copy link

Has this issue been solved yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants